fix: change delete app status code from 204 to 200 (#18398)
Co-authored-by: devxing <devxing@gmail.com> Co-authored-by: crazywoola <427733928@qq.com>
This commit is contained in:
@@ -186,7 +186,7 @@ class AnnotationUpdateDeleteApi(Resource):
|
|||||||
app_id = str(app_id)
|
app_id = str(app_id)
|
||||||
annotation_id = str(annotation_id)
|
annotation_id = str(annotation_id)
|
||||||
AppAnnotationService.delete_app_annotation(app_id, annotation_id)
|
AppAnnotationService.delete_app_annotation(app_id, annotation_id)
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
class AnnotationBatchImportApi(Resource):
|
class AnnotationBatchImportApi(Resource):
|
||||||
|
@@ -84,7 +84,7 @@ class TraceAppConfigApi(Resource):
|
|||||||
result = OpsService.delete_tracing_app_config(app_id=app_id, tracing_provider=args["tracing_provider"])
|
result = OpsService.delete_tracing_app_config(app_id=app_id, tracing_provider=args["tracing_provider"])
|
||||||
if not result:
|
if not result:
|
||||||
raise TracingConfigNotExist()
|
raise TracingConfigNotExist()
|
||||||
return {"result": "success"}
|
return {"result": "success"}, 204
|
||||||
except Exception as e:
|
except Exception as e:
|
||||||
raise BadRequest(str(e))
|
raise BadRequest(str(e))
|
||||||
|
|
||||||
|
@@ -65,7 +65,7 @@ class ApiKeyAuthDataSourceBindingDelete(Resource):
|
|||||||
|
|
||||||
ApiKeyAuthService.delete_provider_auth(current_user.current_tenant_id, binding_id)
|
ApiKeyAuthService.delete_provider_auth(current_user.current_tenant_id, binding_id)
|
||||||
|
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
api.add_resource(ApiKeyAuthDataSource, "/api-key-auth/data-source")
|
api.add_resource(ApiKeyAuthDataSource, "/api-key-auth/data-source")
|
||||||
|
@@ -131,7 +131,7 @@ class DatasetDocumentSegmentListApi(Resource):
|
|||||||
except services.errors.account.NoPermissionError as e:
|
except services.errors.account.NoPermissionError as e:
|
||||||
raise Forbidden(str(e))
|
raise Forbidden(str(e))
|
||||||
SegmentService.delete_segments(segment_ids, document, dataset)
|
SegmentService.delete_segments(segment_ids, document, dataset)
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
class DatasetDocumentSegmentApi(Resource):
|
class DatasetDocumentSegmentApi(Resource):
|
||||||
@@ -333,7 +333,7 @@ class DatasetDocumentSegmentUpdateApi(Resource):
|
|||||||
except services.errors.account.NoPermissionError as e:
|
except services.errors.account.NoPermissionError as e:
|
||||||
raise Forbidden(str(e))
|
raise Forbidden(str(e))
|
||||||
SegmentService.delete_segment(segment, document, dataset)
|
SegmentService.delete_segment(segment, document, dataset)
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
class DatasetDocumentSegmentBatchImportApi(Resource):
|
class DatasetDocumentSegmentBatchImportApi(Resource):
|
||||||
@@ -590,7 +590,7 @@ class ChildChunkUpdateApi(Resource):
|
|||||||
SegmentService.delete_child_chunk(child_chunk, dataset)
|
SegmentService.delete_child_chunk(child_chunk, dataset)
|
||||||
except ChildChunkDeleteIndexServiceError as e:
|
except ChildChunkDeleteIndexServiceError as e:
|
||||||
raise ChildChunkDeleteIndexError(str(e))
|
raise ChildChunkDeleteIndexError(str(e))
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
@setup_required
|
@setup_required
|
||||||
@login_required
|
@login_required
|
||||||
|
@@ -135,7 +135,7 @@ class ExternalApiTemplateApi(Resource):
|
|||||||
raise Forbidden()
|
raise Forbidden()
|
||||||
|
|
||||||
ExternalDatasetService.delete_external_knowledge_api(current_user.current_tenant_id, external_knowledge_api_id)
|
ExternalDatasetService.delete_external_knowledge_api(current_user.current_tenant_id, external_knowledge_api_id)
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
class ExternalApiUseCheckApi(Resource):
|
class ExternalApiUseCheckApi(Resource):
|
||||||
|
@@ -82,7 +82,7 @@ class DatasetMetadataApi(Resource):
|
|||||||
DatasetService.check_dataset_permission(dataset, current_user)
|
DatasetService.check_dataset_permission(dataset, current_user)
|
||||||
|
|
||||||
MetadataService.delete_metadata(dataset_id_str, metadata_id_str)
|
MetadataService.delete_metadata(dataset_id_str, metadata_id_str)
|
||||||
return 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
class DatasetMetadataBuiltInFieldApi(Resource):
|
class DatasetMetadataBuiltInFieldApi(Resource):
|
||||||
|
@@ -113,7 +113,7 @@ class InstalledAppApi(InstalledAppResource):
|
|||||||
db.session.delete(installed_app)
|
db.session.delete(installed_app)
|
||||||
db.session.commit()
|
db.session.commit()
|
||||||
|
|
||||||
return {"result": "success", "message": "App uninstalled successfully"}
|
return {"result": "success", "message": "App uninstalled successfully"}, 204
|
||||||
|
|
||||||
def patch(self, installed_app):
|
def patch(self, installed_app):
|
||||||
parser = reqparse.RequestParser()
|
parser = reqparse.RequestParser()
|
||||||
|
@@ -72,7 +72,7 @@ class SavedMessageApi(InstalledAppResource):
|
|||||||
|
|
||||||
SavedMessageService.delete(app_model, current_user, message_id)
|
SavedMessageService.delete(app_model, current_user, message_id)
|
||||||
|
|
||||||
return {"result": "success"}
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
api.add_resource(
|
api.add_resource(
|
||||||
|
@@ -99,7 +99,7 @@ class APIBasedExtensionDetailAPI(Resource):
|
|||||||
|
|
||||||
APIBasedExtensionService.delete(extension_data_from_db)
|
APIBasedExtensionService.delete(extension_data_from_db)
|
||||||
|
|
||||||
return {"result": "success"}
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
api.add_resource(CodeBasedExtensionAPI, "/code-based-extension")
|
api.add_resource(CodeBasedExtensionAPI, "/code-based-extension")
|
||||||
|
@@ -86,7 +86,7 @@ class TagUpdateDeleteApi(Resource):
|
|||||||
|
|
||||||
TagService.delete_tag(tag_id)
|
TagService.delete_tag(tag_id)
|
||||||
|
|
||||||
return 200
|
return 204
|
||||||
|
|
||||||
|
|
||||||
class TagBindingCreateApi(Resource):
|
class TagBindingCreateApi(Resource):
|
||||||
|
@@ -98,7 +98,7 @@ class AnnotationUpdateDeleteApi(Resource):
|
|||||||
|
|
||||||
annotation_id = str(annotation_id)
|
annotation_id = str(annotation_id)
|
||||||
AppAnnotationService.delete_app_annotation(app_model.id, annotation_id)
|
AppAnnotationService.delete_app_annotation(app_model.id, annotation_id)
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
api.add_resource(AnnotationReplyActionApi, "/apps/annotation-reply/<string:action>")
|
api.add_resource(AnnotationReplyActionApi, "/apps/annotation-reply/<string:action>")
|
||||||
|
@@ -72,7 +72,7 @@ class ConversationDetailApi(Resource):
|
|||||||
ConversationService.delete(app_model, conversation_id, end_user)
|
ConversationService.delete(app_model, conversation_id, end_user)
|
||||||
except services.errors.conversation.ConversationNotExistsError:
|
except services.errors.conversation.ConversationNotExistsError:
|
||||||
raise NotFound("Conversation Not Exists.")
|
raise NotFound("Conversation Not Exists.")
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
class ConversationRenameApi(Resource):
|
class ConversationRenameApi(Resource):
|
||||||
|
@@ -323,7 +323,7 @@ class DocumentDeleteApi(DatasetApiResource):
|
|||||||
except services.errors.document.DocumentIndexingError:
|
except services.errors.document.DocumentIndexingError:
|
||||||
raise DocumentIndexingError("Cannot delete document during indexing.")
|
raise DocumentIndexingError("Cannot delete document during indexing.")
|
||||||
|
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
class DocumentListApi(DatasetApiResource):
|
class DocumentListApi(DatasetApiResource):
|
||||||
|
@@ -63,7 +63,7 @@ class DatasetMetadataServiceApi(DatasetApiResource):
|
|||||||
DatasetService.check_dataset_permission(dataset, current_user)
|
DatasetService.check_dataset_permission(dataset, current_user)
|
||||||
|
|
||||||
MetadataService.delete_metadata(dataset_id_str, metadata_id_str)
|
MetadataService.delete_metadata(dataset_id_str, metadata_id_str)
|
||||||
return 200
|
return 204
|
||||||
|
|
||||||
|
|
||||||
class DatasetMetadataBuiltInFieldServiceApi(DatasetApiResource):
|
class DatasetMetadataBuiltInFieldServiceApi(DatasetApiResource):
|
||||||
|
@@ -159,7 +159,7 @@ class DatasetSegmentApi(DatasetApiResource):
|
|||||||
if not segment:
|
if not segment:
|
||||||
raise NotFound("Segment not found.")
|
raise NotFound("Segment not found.")
|
||||||
SegmentService.delete_segment(segment, document, dataset)
|
SegmentService.delete_segment(segment, document, dataset)
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
@cloud_edition_billing_resource_check("vector_space", "dataset")
|
@cloud_edition_billing_resource_check("vector_space", "dataset")
|
||||||
def post(self, tenant_id, dataset_id, document_id, segment_id):
|
def post(self, tenant_id, dataset_id, document_id, segment_id):
|
||||||
@@ -344,7 +344,7 @@ class DatasetChildChunkApi(DatasetApiResource):
|
|||||||
except ChildChunkDeleteIndexServiceError as e:
|
except ChildChunkDeleteIndexServiceError as e:
|
||||||
raise ChildChunkDeleteIndexError(str(e))
|
raise ChildChunkDeleteIndexError(str(e))
|
||||||
|
|
||||||
return {"result": "success"}, 200
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
@cloud_edition_billing_resource_check("vector_space", "dataset")
|
@cloud_edition_billing_resource_check("vector_space", "dataset")
|
||||||
@cloud_edition_billing_knowledge_limit_check("add_segment", "dataset")
|
@cloud_edition_billing_knowledge_limit_check("add_segment", "dataset")
|
||||||
|
@@ -67,7 +67,7 @@ class SavedMessageApi(WebApiResource):
|
|||||||
|
|
||||||
SavedMessageService.delete(app_model, end_user, message_id)
|
SavedMessageService.delete(app_model, end_user, message_id)
|
||||||
|
|
||||||
return {"result": "success"}
|
return {"result": "success"}, 204
|
||||||
|
|
||||||
|
|
||||||
api.add_resource(SavedMessageListApi, "/saved-messages")
|
api.add_resource(SavedMessageListApi, "/saved-messages")
|
||||||
|
Reference in New Issue
Block a user