estel/dify
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Revert "bug: fix sequence number may be duplicated when multi-threads running the same workflow #21047" (#21207)

Browse Source
This commit is contained in:
QuantumGhost
2025-06-19 12:05:44 +08:00
committed by GitHub
parent 6325129761
commit 2c04a16eaa
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
api/core/repositories/sqlalchemy_workflow_execution_repository.py
View File

@@ -151,17 +151,12 @@ class SQLAlchemyWorkflowExecutionRepository(WorkflowExecutionRepository):
existing = session.scalar(select(WorkflowRun).where(WorkflowRun.id == domain_model.id_)) existing = session.scalar(select(WorkflowRun).where(WorkflowRun.id == domain_model.id_))
if not existing: if not existing:
# For new records, get the next sequence number # For new records, get the next sequence number
# in case multiple executions are created concurrently, use for update stmt = select(func.max(WorkflowRun.sequence_number)).where(
stmt = (
select(func.coalesce(func.max(WorkflowRun.sequence_number), 0) + 1)
.where(
WorkflowRun.app_id == self._app_id, WorkflowRun.app_id == self._app_id,
WorkflowRun.tenant_id == self._tenant_id, WorkflowRun.tenant_id == self._tenant_id,
) )
.with_for_update() max_sequence = session.scalar(stmt)
) db_model.sequence_number = (max_sequence or 0) + 1
next_seq = session.scalar(stmt)
db_model.sequence_number = int(next_seq) if next_seq is not None else 1
else: else:
# For updates, keep the existing sequence number # For updates, keep the existing sequence number
db_model.sequence_number = existing.sequence_number db_model.sequence_number = existing.sequence_number