From 47954aa28469f2913b9eecb53c88b080ca3fab81 Mon Sep 17 00:00:00 2001 From: cutiechi Date: Thu, 3 Jul 2025 14:50:53 +0800 Subject: [PATCH] feat(api): validate and reject external datasets in document update (#21783) --- api/controllers/service_api/dataset/document.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/api/controllers/service_api/dataset/document.py b/api/controllers/service_api/dataset/document.py index d64d9df05..d571b21a0 100644 --- a/api/controllers/service_api/dataset/document.py +++ b/api/controllers/service_api/dataset/document.py @@ -211,6 +211,9 @@ class DocumentAddByFileApi(DatasetApiResource): if not dataset: raise ValueError("Dataset does not exist.") + if dataset.provider == "external": + raise ValueError("External datasets are not supported.") + indexing_technique = args.get("indexing_technique") or dataset.indexing_technique if not indexing_technique: raise ValueError("indexing_technique is required.") @@ -301,6 +304,9 @@ class DocumentUpdateByFileApi(DatasetApiResource): if not dataset: raise ValueError("Dataset does not exist.") + if dataset.provider == "external": + raise ValueError("External datasets are not supported.") + # indexing_technique is already set in dataset since this is an update args["indexing_technique"] = dataset.indexing_technique