estel/dify
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: unify log format, use placeholders instead of string concatenation (#24544)

Browse Source
This commit is contained in:
GuanMu
2025-08-26 15:45:16 +08:00
committed by GitHub
parent bfc4fe1a9a
commit 47f480c0dc
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/core/llm_generator/llm_generator.py
View File

@@ -570,5 +570,5 @@ class LLMGenerator:
error = str(e) error = str(e)
return {"error": f"Failed to generate code. Error: {error}"} return {"error": f"Failed to generate code. Error: {error}"}
except Exception as e: except Exception as e:
logging.exception("Failed to invoke LLM model, model: " + json.dumps(model_config.get("name")), exc_info=e) logging.exception("Failed to invoke LLM model, model: %s", model_config.get("name"), exc_info=e)
return {"error": f"An unexpected error occurred: {str(e)}"} return {"error": f"An unexpected error occurred: {str(e)}"}

4
api/core/rag/datasource/vdb/tidb_vector/tidb_vector.py
View File

@@ -83,14 +83,14 @@ class TiDBVector(BaseVector):
self._dimension = 1536 self._dimension = 1536
def create(self, texts: list[Document], embeddings: list[list[float]], **kwargs): def create(self, texts: list[Document], embeddings: list[list[float]], **kwargs):
logger.info("create collection and add texts, collection_name: " + self._collection_name) logger.info("create collection and add texts, collection_name: %s", self._collection_name)
self._create_collection(len(embeddings[0])) self._create_collection(len(embeddings[0]))
self.add_texts(texts, embeddings) self.add_texts(texts, embeddings)
self._dimension = len(embeddings[0]) self._dimension = len(embeddings[0])
pass pass
def _create_collection(self, dimension: int): def _create_collection(self, dimension: int):
logger.info("_create_collection, collection_name " + self._collection_name) logger.info("_create_collection, collection_name %s", self._collection_name)
lock_name = f"vector_indexing_lock_{self._collection_name}" lock_name = f"vector_indexing_lock_{self._collection_name}"
with redis_client.lock(lock_name, timeout=20): with redis_client.lock(lock_name, timeout=20):
collection_exist_cache_key = f"vector_indexing_{self._collection_name}" collection_exist_cache_key = f"vector_indexing_{self._collection_name}"

2
api/core/rag/embedding/cached_embedding.py
View File

@@ -95,7 +95,7 @@ class CacheEmbedding(Embeddings):
db.session.rollback() db.session.rollback()
except Exception as ex: except Exception as ex:
db.session.rollback() db.session.rollback()
logger.exception("Failed to embed documents: %s") logger.exception("Failed to embed documents")
raise ex raise ex
return text_embeddings return text_embeddings