From 7c7618c083cb925c913c1115f3154a7f610d628c Mon Sep 17 00:00:00 2001
From: Yongtao Huang <yongtaoh2022@gmail.com>
Date: Tue, 19 Aug 2025 18:27:30 +0800
Subject: [PATCH] Remove the second `if self.runtime is None:` check (#24171)

Co-authored-by: Yongtao Huang <99629139+hyongtao-db@users.noreply.github.com>
---
 api/core/tools/custom_tool/tool.py      | 5 +----
 api/core/tools/entities/api_entities.py | 2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/api/core/tools/custom_tool/tool.py b/api/core/tools/custom_tool/tool.py
index e112de957..3c0bfa524 100644
--- a/api/core/tools/custom_tool/tool.py
+++ b/api/core/tools/custom_tool/tool.py
@@ -81,14 +81,11 @@ class ApiTool(Tool):
         return ToolProviderType.API
 
     def assembling_request(self, parameters: dict[str, Any]) -> dict[str, Any]:
+        headers = {}
         if self.runtime is None:
             raise ToolProviderCredentialValidationError("runtime not initialized")
 
-        headers = {}
-        if self.runtime is None:
-            raise ValueError("runtime is required")
         credentials = self.runtime.credentials or {}
-
         if "auth_type" not in credentials:
             raise ToolProviderCredentialValidationError("Missing auth_type")
 
diff --git a/api/core/tools/entities/api_entities.py b/api/core/tools/entities/api_entities.py
index 27ce96b90..48015c04e 100644
--- a/api/core/tools/entities/api_entities.py
+++ b/api/core/tools/entities/api_entities.py
@@ -62,7 +62,7 @@ class ToolProviderApiEntity(BaseModel):
                         parameter.pop("input_schema", None)
         # -------------
         optional_fields = self.optional_field("server_url", self.server_url)
-        if self.type == ToolProviderType.MCP.value:
+        if self.type == ToolProviderType.MCP:
             optional_fields.update(self.optional_field("updated_at", self.updated_at))
             optional_fields.update(self.optional_field("server_identifier", self.server_identifier))
         return {