From 7fe23a0ca65562b2b067296c712daa84087f9660 Mon Sep 17 00:00:00 2001
From: Will <vvfriday@gmail.com>
Date: Tue, 5 Aug 2025 10:20:28 +0800
Subject: [PATCH] remove useless Tool class attributes (#23389)

---
 api/core/tools/__base/tool.py                  | 3 ---
 api/core/tools/builtin_tool/tool.py            | 2 --
 api/core/tools/custom_tool/tool.py             | 3 ---
 api/core/tools/mcp_tool/tool.py                | 9 +--------
 api/core/tools/plugin_tool/tool.py             | 7 +------
 api/core/tools/utils/dataset_retriever_tool.py | 2 --
 api/core/tools/workflow_as_tool/tool.py        | 9 ---------
 7 files changed, 2 insertions(+), 33 deletions(-)

diff --git a/api/core/tools/__base/tool.py b/api/core/tools/__base/tool.py
index 35e16b5c8..d6961cdaa 100644
--- a/api/core/tools/__base/tool.py
+++ b/api/core/tools/__base/tool.py
@@ -20,9 +20,6 @@ class Tool(ABC):
     The base class of a tool
     """
 
-    entity: ToolEntity
-    runtime: ToolRuntime
-
     def __init__(self, entity: ToolEntity, runtime: ToolRuntime) -> None:
         self.entity = entity
         self.runtime = runtime
diff --git a/api/core/tools/builtin_tool/tool.py b/api/core/tools/builtin_tool/tool.py
index 724a2291c..84efefba0 100644
--- a/api/core/tools/builtin_tool/tool.py
+++ b/api/core/tools/builtin_tool/tool.py
@@ -20,8 +20,6 @@ class BuiltinTool(Tool):
     :param meta: the meta data of a tool call processing
     """
 
-    provider: str
-
     def __init__(self, provider: str, **kwargs):
         super().__init__(**kwargs)
         self.provider = provider
diff --git a/api/core/tools/custom_tool/tool.py b/api/core/tools/custom_tool/tool.py
index 10653b994..333ef2834 100644
--- a/api/core/tools/custom_tool/tool.py
+++ b/api/core/tools/custom_tool/tool.py
@@ -21,9 +21,6 @@ API_TOOL_DEFAULT_TIMEOUT = (
 
 
 class ApiTool(Tool):
-    api_bundle: ApiToolBundle
-    provider_id: str
-
     """
     Api tool
     """
diff --git a/api/core/tools/mcp_tool/tool.py b/api/core/tools/mcp_tool/tool.py
index d1bacbc73..8ebbb6b0f 100644
--- a/api/core/tools/mcp_tool/tool.py
+++ b/api/core/tools/mcp_tool/tool.py
@@ -8,23 +8,16 @@ from core.mcp.mcp_client import MCPClient
 from core.mcp.types import ImageContent, TextContent
 from core.tools.__base.tool import Tool
 from core.tools.__base.tool_runtime import ToolRuntime
-from core.tools.entities.tool_entities import ToolEntity, ToolInvokeMessage, ToolParameter, ToolProviderType
+from core.tools.entities.tool_entities import ToolEntity, ToolInvokeMessage, ToolProviderType
 
 
 class MCPTool(Tool):
-    tenant_id: str
-    icon: str
-    runtime_parameters: Optional[list[ToolParameter]]
-    server_url: str
-    provider_id: str
-
     def __init__(
         self, entity: ToolEntity, runtime: ToolRuntime, tenant_id: str, icon: str, server_url: str, provider_id: str
     ) -> None:
         super().__init__(entity, runtime)
         self.tenant_id = tenant_id
         self.icon = icon
-        self.runtime_parameters = None
         self.server_url = server_url
         self.provider_id = provider_id
 
diff --git a/api/core/tools/plugin_tool/tool.py b/api/core/tools/plugin_tool/tool.py
index aef2677c3..db38c10e8 100644
--- a/api/core/tools/plugin_tool/tool.py
+++ b/api/core/tools/plugin_tool/tool.py
@@ -9,11 +9,6 @@ from core.tools.entities.tool_entities import ToolEntity, ToolInvokeMessage, Too
 
 
 class PluginTool(Tool):
-    tenant_id: str
-    icon: str
-    plugin_unique_identifier: str
-    runtime_parameters: Optional[list[ToolParameter]]
-
     def __init__(
         self, entity: ToolEntity, runtime: ToolRuntime, tenant_id: str, icon: str, plugin_unique_identifier: str
     ) -> None:
@@ -21,7 +16,7 @@ class PluginTool(Tool):
         self.tenant_id = tenant_id
         self.icon = icon
         self.plugin_unique_identifier = plugin_unique_identifier
-        self.runtime_parameters = None
+        self.runtime_parameters: Optional[list[ToolParameter]] = None
 
     def tool_provider_type(self) -> ToolProviderType:
         return ToolProviderType.PLUGIN
diff --git a/api/core/tools/utils/dataset_retriever_tool.py b/api/core/tools/utils/dataset_retriever_tool.py
index ec0575f6c..d58807e29 100644
--- a/api/core/tools/utils/dataset_retriever_tool.py
+++ b/api/core/tools/utils/dataset_retriever_tool.py
@@ -20,8 +20,6 @@ from core.tools.utils.dataset_retriever.dataset_retriever_base_tool import Datas
 
 
 class DatasetRetrieverTool(Tool):
-    retrieval_tool: DatasetRetrieverBaseTool
-
     def __init__(self, entity: ToolEntity, runtime: ToolRuntime, retrieval_tool: DatasetRetrieverBaseTool) -> None:
         super().__init__(entity, runtime)
         self.retrieval_tool = retrieval_tool
diff --git a/api/core/tools/workflow_as_tool/tool.py b/api/core/tools/workflow_as_tool/tool.py
index db6b84082..6824e5e0e 100644
--- a/api/core/tools/workflow_as_tool/tool.py
+++ b/api/core/tools/workflow_as_tool/tool.py
@@ -25,15 +25,6 @@ logger = logging.getLogger(__name__)
 
 
 class WorkflowTool(Tool):
-    workflow_app_id: str
-    version: str
-    workflow_entities: dict[str, Any]
-    workflow_call_depth: int
-    thread_pool_id: Optional[str] = None
-    workflow_as_tool_id: str
-
-    label: str
-
     """
     Workflow tool.
     """