Revert "fix: fix duplicate app lose custom image" (#19995)
This commit is contained in:
@@ -100,7 +100,6 @@ class PendingData(BaseModel):
|
||||
description: str | None
|
||||
icon_type: str | None
|
||||
icon: str | None
|
||||
icon_url: str | None
|
||||
icon_background: str | None
|
||||
app_id: str | None
|
||||
|
||||
@@ -125,7 +124,6 @@ class AppDslService:
|
||||
description: Optional[str] = None,
|
||||
icon_type: Optional[str] = None,
|
||||
icon: Optional[str] = None,
|
||||
icon_url: Optional[str] = None,
|
||||
icon_background: Optional[str] = None,
|
||||
app_id: Optional[str] = None,
|
||||
) -> Import:
|
||||
@@ -250,7 +248,6 @@ class AppDslService:
|
||||
icon_type=icon_type,
|
||||
icon=icon,
|
||||
icon_background=icon_background,
|
||||
icon_url=icon_url,
|
||||
app_id=app_id,
|
||||
)
|
||||
redis_client.setex(
|
||||
@@ -291,7 +288,6 @@ class AppDslService:
|
||||
description=description,
|
||||
icon_type=icon_type,
|
||||
icon=icon,
|
||||
icon_url=icon_url,
|
||||
icon_background=icon_background,
|
||||
dependencies=check_dependencies_pending_data,
|
||||
)
|
||||
@@ -413,7 +409,6 @@ class AppDslService:
|
||||
description: Optional[str] = None,
|
||||
icon_type: Optional[str] = None,
|
||||
icon: Optional[str] = None,
|
||||
icon_url: Optional[str] = None,
|
||||
icon_background: Optional[str] = None,
|
||||
dependencies: Optional[list[PluginDependency]] = None,
|
||||
) -> App:
|
||||
@@ -426,12 +421,12 @@ class AppDslService:
|
||||
|
||||
# Set icon type
|
||||
icon_type_value = icon_type or app_data.get("icon_type")
|
||||
if icon_type_value in ["emoji", "link", "image"]:
|
||||
if icon_type_value in ["emoji", "link"]:
|
||||
icon_type = icon_type_value
|
||||
else:
|
||||
icon_type = "emoji"
|
||||
icon = icon or str(app_data.get("icon", ""))
|
||||
icon_url = icon_url or str(app_data.get("icon_url", ""))
|
||||
|
||||
if app:
|
||||
# Update existing app
|
||||
app.name = name or app_data.get("name", app.name)
|
||||
@@ -439,7 +434,6 @@ class AppDslService:
|
||||
app.icon_type = icon_type
|
||||
app.icon = icon
|
||||
app.icon_background = icon_background or app_data.get("icon_background", app.icon_background)
|
||||
app.icon_url = icon_url or app_data.get("icon_url", app.icon_url)
|
||||
app.updated_by = account.id
|
||||
else:
|
||||
if account.current_tenant_id is None:
|
||||
|
Reference in New Issue
Block a user