chore: eslint add sonar (#17989)

web/app/components/workflow/nodes/_base/components/editor/code-editor/editor-support-vars.tsx

@@ -84,7 +84,7 @@ const CodeEditor: FC<Props> = ({
 
   const getUniqVarName = (varName: string) => {
     if (varList.find(v => v.variable === varName)) {
-      const match = varName.match(/_([0-9]+)$/)
+      const match = varName.match(/_(\d+)$/)
 
       const index = (() => {
         if (match)
@@ -92,7 +92,7 @@ const CodeEditor: FC<Props> = ({
 
         return 1
       })()
-      return getUniqVarName(`${varName.replace(/_([0-9]+)$/, '')}_${index}`)
+      return getUniqVarName(`${varName.replace(/_(\d+)$/, '')}_${index}`)
     }
     return varName
   }

web/app/components/workflow/nodes/_base/components/variable/utils.ts

@@ -278,6 +278,7 @@ const formatItem = (
       break
     }
 
+    // eslint-disable-next-line sonarjs/no-duplicated-branches
     case BlockEnum.VariableAggregator: {
       const {
         output_type,
@@ -466,7 +467,7 @@ const formatItem = (
   res.vars = res.vars.filter((v) => {
     const isCurrentMatched = filterVar(v, (() => {
       const variableArr = v.variable.split('.')
-      const [first, ..._other] = variableArr
+      const [first] = variableArr
       if (first === 'sys' || first === 'env' || first === 'conversation')
         return variableArr
 
@@ -611,6 +612,7 @@ const getLoopItemType = ({
 }: {
   valueSelector: ValueSelector
   beforeNodesOutputVars: NodeOutPutVar[]
+  // eslint-disable-next-line sonarjs/no-identical-functions
 }): VarType => {
   const outputVarNodeId = valueSelector[0]
   const isSystem = isSystemVar(valueSelector)
@@ -1243,6 +1245,7 @@ export const updateNodeVars = (oldNode: Node, oldVarSelector: ValueSelector, new
         }
         break
       }
+      // eslint-disable-next-line sonarjs/no-duplicated-branches
       case BlockEnum.VariableAggregator: {
         const payload = data as VariableAssignerNodeType
         if (payload.variables) {

web/app/components/workflow/nodes/_base/components/variable/var-reference-vars.tsx

@@ -64,7 +64,7 @@ const Item: FC<ItemProps> = ({
   const isChatVar = itemData.variable.startsWith('conversation.')
   const itemRef = useRef<HTMLDivElement>(null)
   const [isItemHovering, setIsItemHovering] = useState(false)
-  const _ = useHover(itemRef, {
+  useHover(itemRef, {
     onChange: (hovering) => {
       if (hovering) {
         setIsItemHovering(true)
@@ -185,7 +185,7 @@ const ObjectChildren: FC<ObjectChildrenProps> = ({
   const currObjPath = objPath
   const itemRef = useRef<HTMLDivElement>(null)
   const [isItemHovering, setIsItemHovering] = useState(false)
-  const _ = useHover(itemRef, {
+  useHover(itemRef, {
     onChange: (hovering) => {
       if (hovering) {
         setIsItemHovering(true)

web/app/components/workflow/nodes/agent/default.ts

@@ -97,7 +97,7 @@ const nodeDefault: NodeDefault<AgentNodeType> = {
         }
         // check form of tools
         else {
-          let validState = {
+          const validState = {
             isValid: true,
             errorMessage: '',
           }
@@ -108,13 +108,13 @@ const nodeDefault: NodeDefault<AgentNodeType> = {
             schemas.forEach((schema: any) => {
               if (schema?.required) {
                 if (schema.form === 'form' && !userSettings[schema.name]?.value) {
-                  return validState = {
+                  return {
                     isValid: false,
                     errorMessage: t('workflow.errorMsg.toolParameterRequired', { field: renderI18nObject(param.label, language), param: renderI18nObject(schema.label, language) }),
                   }
                 }
                 if (schema.form === 'llm' && reasoningConfig[schema.name]?.auto === 0 && !reasoningConfig[schema.name]?.value) {
-                  return validState = {
+                  return {
                     isValid: false,
                     errorMessage: t('workflow.errorMsg.toolParameterRequired', { field: renderI18nObject(param.label, language), param: renderI18nObject(schema.label, language) }),
                   }

web/app/components/workflow/nodes/agent/node.tsx

@@ -102,6 +102,7 @@ const AgentNode: FC<NodeProps<AgentNodeType>> = (props) => {
       {t('workflow.nodes.agent.toolbox')}
     </GroupLabel>}>
       <div className='grid grid-cols-10 gap-0.5'>
+        {/* eslint-disable-next-line sonarjs/no-uniq-key */}
         {tools.map(tool => <ToolIcon {...tool} key={Math.random()} />)}
       </div>
     </Group>}

web/app/components/workflow/nodes/end/default.ts

@@ -16,16 +16,10 @@ const nodeDefault: NodeDefault<EndNodeType> = {
   getAvailableNextNodes() {
     return []
   },
-  checkValid(payload: EndNodeType) {
-    let isValid = true
-    let errorMessages = ''
-    if (payload.type) {
-      isValid = true
-      errorMessages = ''
-    }
+  checkValid() {
     return {
-      isValid,
-      errorMessage: errorMessages,
+      isValid: true,
+      errorMessage: '',
     }
   },
 }

web/app/components/workflow/nodes/knowledge-retrieval/components/metadata/condition-list/utils.ts

@@ -62,5 +62,5 @@ export const comparisonOperatorNotRequireValue = (operator?: ComparisonOperator)
   return [ComparisonOperator.empty, ComparisonOperator.notEmpty, ComparisonOperator.isNull, ComparisonOperator.isNotNull, ComparisonOperator.exists, ComparisonOperator.notExists].includes(operator)
 }
 
-export const VARIABLE_REGEX = /\{\{(#[a-zA-Z0-9_-]{1,50}(\.[a-zA-Z_][a-zA-Z0-9_]{0,29}){1,10}#)\}\}/gi
+export const VARIABLE_REGEX = /\{\{(#[a-zA-Z0-9_-]{1,50}(\.[a-zA-Z_]\w{0,29}){1,10}#)\}\}/gi
 export const COMMON_VARIABLE_REGEX = /\{\{([a-zA-Z0-9_-]{1,50})\}\}/gi

web/app/components/workflow/nodes/knowledge-retrieval/utils.ts

@@ -36,7 +36,6 @@ export const getSelectedDatasetsMode = (datasets: DataSet[] = []) => {
     allHighQualityFullTextSearch = false
     allEconomic = false
     mixtureHighQualityAndEconomic = false
-    inconsistentEmbeddingModel = false
     allExternal = false
     allInternal = false
     mixtureInternalAndExternal = false