estel/dify
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: add missing db.session.close() to ensure proper session cleanup (#23122)

Browse Source
This commit is contained in:
Yongtao Huang
2025-07-30 10:34:24 +08:00
committed by GitHub
parent 0ea010d7ee
commit f17ca26b10
3 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/tasks/add_document_to_index_task.py
View File

@@ -32,6 +32,7 @@ def add_document_to_index_task(dataset_document_id: str):
return return
if dataset_document.indexing_status != "completed": if dataset_document.indexing_status != "completed":
db.session.close()
return return
indexing_cache_key = f"document_{dataset_document.id}_indexing" indexing_cache_key = f"document_{dataset_document.id}_indexing"
@@ -112,3 +113,4 @@ def add_document_to_index_task(dataset_document_id: str):
db.session.commit() db.session.commit()
finally: finally:
redis_client.delete(indexing_cache_key) redis_client.delete(indexing_cache_key)
db.session.close()

1
api/tasks/create_segment_to_index_task.py
View File

@@ -31,6 +31,7 @@ def create_segment_to_index_task(segment_id: str, keywords: Optional[list[str]]
return return
if segment.status != "waiting": if segment.status != "waiting":
db.session.close()
return return
indexing_cache_key = f"segment_{segment.id}_indexing" indexing_cache_key = f"segment_{segment.id}_indexing"

2
api/tasks/document_indexing_sync_task.py
View File

@@ -113,3 +113,5 @@ def document_indexing_sync_task(dataset_id: str, document_id: str):
logging.info(click.style(str(ex), fg="yellow")) logging.info(click.style(str(ex), fg="yellow"))
except Exception: except Exception:
logging.exception("document_indexing_sync_task failed, document_id: %s", document_id) logging.exception("document_indexing_sync_task failed, document_id: %s", document_id)
finally:
db.session.close()