estel/netbox
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

Fixes #19230: Allow label reuse when creating multiple components from a pattern (#19261)

Browse Source
This commit is contained in:
Jeremy Stretch
2025-04-22 11:55:31 -04:00
committed by GitHub
parent 60cdf89cad
commit 13ddd5fd20
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
netbox/dcim/forms/object_create.py
View File

@@ -55,14 +55,18 @@ class ComponentCreateForm(forms.Form):
def clean(self):
super().clean()
# Validate that all replication fields generate an equal number of values
# Validate that all replication fields generate an equal number of values (or a single value)
if not (patterns := self.cleaned_data.get(self.replication_fields[0])):
return
pattern_count = len(patterns)
for field_name in self.replication_fields:
value_count = len(self.cleaned_data[field_name])
if self.cleaned_data[field_name] and value_count != pattern_count:
if self.cleaned_data[field_name]:
if value_count == 1:
# If the field resolves to a single value (because no pattern was used), multiply it by the number
# of expected values. This allows us to reuse the same label when creating multiple components.
self.cleaned_data[field_name] = self.cleaned_data[field_name] * pattern_count
elif value_count != pattern_count:
raise forms.ValidationError({
field_name: _(
"The provided pattern specifies {value_count} values, but {pattern_count} are expected."