Optimized bulk editing of custom fields

2016-08-17 15:52:27 -04:00
parent a33e89fed7
commit 9bdb50c33e
3 changed files with 35 additions and 26 deletions
--- a/netbox/extras/models.py
+++ b/netbox/extras/models.py
@@ -155,9 +155,9 @@ class CustomFieldValue(models.Model):
        self.serialized_value = self.field.serialize_value(value)

    def save(self, *args, **kwargs):
-        if (self.field.type == CF_TYPE_TEXT and self.value == '') or self.value is None:
-            if self.pk:
-                self.delete()
+        # Delete this object if it no longer has a value to store
+        if self.pk and self.value is None:
+            self.delete()
        else:
            super(CustomFieldValue, self).save(*args, **kwargs)